Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete ticket only when saved #4692

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 31, 2020

Fixes #4676

Short description of what this resolves:

Tickets can be deleted without hitting save which is wrong.

Changes proposed in this pull request:

Store deleted tickets in an array and delete them permanently only when organizer hits the save button.

delete-ticket

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7ejyeak2g
✅ Preview: https://open-event-frontend-git-fork-haider8-delete-ticket-when-save.eventyay.vercel.app

@Haider8
Copy link
Contributor Author

Haider8 commented Jul 31, 2020

@iamareebjamal Please review and let me know if this is the correct approach.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #4692 into development will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4692      +/-   ##
===============================================
- Coverage        23.11%   23.08%   -0.03%     
===============================================
  Files              476      476              
  Lines             4975     4981       +6     
  Branches             8        8              
===============================================
  Hits              1150     1150              
- Misses            3824     3830       +6     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/forms/wizard/basic-details-step.js 24.39% <0.00%> (-0.31%) ⬇️
app/mixins/event-wizard.js 1.14% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91cd31...4c70fcb. Read the comment docs.

@iamareebjamal
Copy link
Member

Initialize an empty array in the component and push it there instead of if else

@Haider8 Haider8 requested a review from iamareebjamal August 4, 2020 10:19
@Haider8 Haider8 changed the title [WIP] fix: Delete ticket only when saved fix: Delete ticket only when saved Aug 4, 2020
@auto-label auto-label bot added the fix label Aug 4, 2020
@iamareebjamal iamareebjamal merged commit d1619a8 into fossasia:development Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test and ensure event data is only changed after organizer hits save button
2 participants