-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Delete ticket only when saved #4692
fix: Delete ticket only when saved #4692
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7ejyeak2g |
@iamareebjamal Please review and let me know if this is the correct approach. |
Codecov Report
@@ Coverage Diff @@
## development #4692 +/- ##
===============================================
- Coverage 23.11% 23.08% -0.03%
===============================================
Files 476 476
Lines 4975 4981 +6
Branches 8 8
===============================================
Hits 1150 1150
- Misses 3824 3830 +6
Partials 1 1
Continue to review full report at Codecov.
|
Initialize an empty array in the component and push it there instead of if else |
Fixes #4676
Short description of what this resolves:
Tickets can be deleted without hitting save which is wrong.
Changes proposed in this pull request:
Store deleted tickets in an array and delete them permanently only when organizer hits the save button.
Checklist
development
branch.