-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Left align footer and capitalize item #4690
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pjhuq34g6 |
I have used semantics UI to align the columns as suggested by @snitin315 |
Codecov Report
@@ Coverage Diff @@
## development #4690 +/- ##
============================================
Coverage 23.08% 23.08%
============================================
Files 476 476
Lines 4972 4972
Branches 8 8
============================================
Hits 1148 1148
Misses 3823 3823
Partials 1 1 Continue to review full report at Codecov.
|
Please review my PR @snitin315 @mariobehling @iamareebjamal |
Please rename PR title according to semantic guidelines |
Where can I take reference for semantic guidelines? |
See merged PRs title |
Changed the PR title , please review it @iamareebjamal @snitin315 @mariobehling |
@iamareebjamal sir can you too review the PR ? |
Proper title should mention specific fixes. "Simplify footer" is too generic "Left align footer and capitalize item" |
And it was a fix |
oh okay thanks |
Fixes #4612 - author @mariobehling
Short description of what this resolves:
This aligns the footer columns to left using semantic UI classes and corrects the capitalization in one footer heading
Changes proposed in this pull request:
-left align the footer columns
-Heading "Connect With Us"-> capital 'W' in "with", capital 'U' in "us"
Checklist
development
branch.