Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Left align footer and capitalize item #4690

Merged
merged 2 commits into from
Jul 31, 2020
Merged

feat: Left align footer and capitalize item #4690

merged 2 commits into from
Jul 31, 2020

Conversation

chetas411
Copy link
Contributor

Fixes #4612 - author @mariobehling

Short description of what this resolves:

This aligns the footer columns to left using semantic UI classes and corrects the capitalization in one footer heading

Changes proposed in this pull request:

-left align the footer columns
-Heading "Connect With Us"-> capital 'W' in "with", capital 'U' in "us"

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
    open event footer

@vercel
Copy link

vercel bot commented Jul 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pjhuq34g6
✅ Preview: https://open-event-frontend-git-fork-chetas411-development.eventyay.vercel.app

@chetas411
Copy link
Contributor Author

I have used semantics UI to align the columns as suggested by @snitin315

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #4690 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4690   +/-   ##
============================================
  Coverage        23.08%   23.08%           
============================================
  Files              476      476           
  Lines             4972     4972           
  Branches             8        8           
============================================
  Hits              1148     1148           
  Misses            3823     3823           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed712a...1d75ea0. Read the comment docs.

@chetas411
Copy link
Contributor Author

Please review my PR @snitin315 @mariobehling @iamareebjamal

@iamareebjamal
Copy link
Member

Please rename PR title according to semantic guidelines

@chetas411
Copy link
Contributor Author

Where can I take reference for semantic guidelines?

@iamareebjamal
Copy link
Member

See merged PRs title

@chetas411 chetas411 changed the title fixed capitalization in footer heading and left aligned the footer columns feat: Simplify footer Jul 31, 2020
@auto-label auto-label bot added the feature label Jul 31, 2020
@chetas411
Copy link
Contributor Author

chetas411 commented Jul 31, 2020

See merged PRs title

Changed the PR title , please review it @iamareebjamal @snitin315 @mariobehling

@chetas411
Copy link
Contributor Author

@iamareebjamal sir can you too review the PR ?

@iamareebjamal
Copy link
Member

Proper title should mention specific fixes. "Simplify footer" is too generic

"Left align footer and capitalize item"

@iamareebjamal iamareebjamal changed the title feat: Simplify footer feat: Left align footer and capitalize item Jul 31, 2020
@iamareebjamal iamareebjamal merged commit 7011e32 into fossasia:development Jul 31, 2020
@iamareebjamal
Copy link
Member

And it was a fix

@chetas411
Copy link
Contributor Author

And it was a fix

oh okay thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify footer and change to 4 column instead of 5 column
3 participants