Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use selected for attendee order-form dropdowns #4654

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 28, 2020

Fixes #4619

Short description of what this resolves:

Attendee order-form dropdowns for gender, country and ageGroup needs to be double clicked in order to select it which is wrong.

Changes proposed in this pull request:

Use selected in order to select that particular option

attendee-dropdowns

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/inn9qeasa
✅ Preview: https://open-event-frontend-git-fork-haider8-attendee-dropdowns.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #4654 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4654      +/-   ##
===============================================
+ Coverage        23.05%   23.08%   +0.02%     
===============================================
  Files              475      475              
  Lines             4957     4952       -5     
  Branches             8        8              
===============================================
  Hits              1143     1143              
+ Misses            3813     3808       -5     
  Partials             1        1              
Impacted Files Coverage Δ
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/components/public/call-for-speakers.js 0.00% <0.00%> (ø)
app/components/modals/publish-unpublish-modal.js
app/components/modals/cfs-proposal-modal.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27f444...1acc354. Read the comment docs.

@iamareebjamal
Copy link
Member

Try using just value and remove onChange. Not sure why both were used. Using selected and onChange with duplicate code, when there is value, seems wrong

@Haider8
Copy link
Contributor Author

Haider8 commented Jul 29, 2020

Try using just value and remove onChange

@iamareebjamal Not working too!

@iamareebjamal
Copy link
Member

OK

@iamareebjamal iamareebjamal merged commit f7317ed into fossasia:development Jul 29, 2020
@Haider8 Haider8 deleted the attendee-dropdowns branch July 29, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forms: Gender Fields need to be clicked twice
2 participants