fix: Enable link on view and edit in event overview #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/it9qlmbvg |
Codecov Report
@@ Coverage Diff @@
## development #4643 +/- ##
===============================================
+ Coverage 23.04% 23.08% +0.03%
===============================================
Files 475 475
Lines 4959 4952 -7
Branches 8 8
===============================================
Hits 1143 1143
+ Misses 3815 3808 -7
Partials 1 1
Continue to review full report at Codecov.
|
| <UiPopup @tagName="a" @click={{action this.props.actions.moveToDetails this.extraRecords.identifier}} @content={{t "Event Dashboard"}} @class="ui icon button" @position="top center"> | ||
| <i class="tasks icon"></i> | ||
| </UiPopup> | ||
| <UiPopup @tagName="a" @click={{action this.props.actions.moveToPublic this.extraRecords.identifier}} @content={{t "View"}} @class="ui icon button" @position="top center"> |
There was a problem hiding this comment.
If moveToPublic isn't being used now, please remove it from code
iamareebjamal
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4212
Short description of what this resolves:
There was no link on view and edit in event overview page.
Changes proposed in this pull request:
Use link for for view and edit
Checklist
developmentbranch.