Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert session state on failure #4642

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 27, 2020

Fixes #4641

@vercel
Copy link

vercel bot commented Jul 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2o0t9e4lv
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-session-revert.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #4642 into development will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4642      +/-   ##
===============================================
- Coverage        23.07%   23.04%   -0.03%     
===============================================
  Files              475      475              
  Lines             4954     4959       +5     
  Branches             8        8              
===============================================
  Hits              1143     1143              
- Misses            3810     3815       +5     
  Partials             1        1              
Impacted Files Coverage Δ
app/controllers/events/view/sessions/list.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0922c63...8966ac4. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 579db43 into fossasia:development Jul 27, 2020
@iamareebjamal iamareebjamal deleted the session-revert branch July 27, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert session state if change fails
1 participant