Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use checkbox for adding new proposal in create speaker form #4571

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 17, 2020

Fixes #4027

Short description of what this resolves:

In create speaker form we can't check and uncheck add a new proposal

Changes proposed in this pull request:

Use checkbox for add new proposal
checkbox-add-proposal

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 17, 2020
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #4571 into development will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4571      +/-   ##
===============================================
+ Coverage        22.21%   22.28%   +0.06%     
===============================================
  Files              473      473              
  Lines             4975     4973       -2     
  Branches             8        8              
===============================================
+ Hits              1105     1108       +3     
+ Misses            3869     3864       -5     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/forms/session-speaker-form.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafb486...414ee9d. Read the comment docs.

@Haider8
Copy link
Contributor Author

Haider8 commented Jul 17, 2020

@iamareebjamal Please review

@vercel
Copy link

vercel bot commented Jul 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ga9r2aqmv
✅ Preview: https://open-event-frontend-git-fork-haider8-issue-4027.eventyay.vercel.app

@mariobehling
Copy link
Member

This is actually illogical. I missed the point where this was changed to a working earlier version.

A random speaker who signs up on the platform should not be able to add him or herself to an existing session proposal. This should only be possible if a speaker gets an invitation to an existing proposal by an existing speaker.

Therefore this needs to be changed. The slider needs to be taken out and the "add proposal area" should always show up.

@mariobehling
Copy link
Member

Ok, now I understand. This is only for organizers. It seems to work. However, if I create a session and then unslide it, it will already create an empty session and stores it in the system.

@mariobehling
Copy link
Member

I added an issue to follow up here #4575
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In session speaker form add a new session should be checkbox
3 participants