Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assign custom form name on init #4507

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jun 30, 2020

New field 'name' was added in custom form and it is
populated from backend, so new custom forms in
frontend were initialized without any name because
the previous logic of loading name as custom property
was removed. This is a temporary fix since custom forms
will start to be created on backend instead of frontend

Fixes #4506

New field 'name' was added in custom form and it is
populated from backend, so new custom forms in
frontend were initialized without any name because
the previous logic of loading name as custom property
was removed. This is a temporary fix since custom forms
will start to be created on backend instead of frontend
@vercel
Copy link

vercel bot commented Jun 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8h2lz7pak
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-custom-form-name.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #4507 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4507      +/-   ##
===============================================
- Coverage        22.26%   22.25%   -0.01%     
===============================================
  Files              470      470              
  Lines             4958     4960       +2     
  Branches             6        6              
===============================================
  Hits              1104     1104              
- Misses            3853     3855       +2     
  Partials             1        1              
Impacted Files Coverage Δ
app/models/custom-form.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554e64e...b7f9775. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 0977d1e into fossasia:development Jun 30, 2020
@iamareebjamal iamareebjamal deleted the custom-form-name branch June 30, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 4 Sessions and Speakers: Customize Speaker Form Left Column Text Disappeared
1 participant