-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add attendee custom form option #4480
feat: Add attendee custom form option #4480
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/300rd8hh1 |
Codecov Report
@@ Coverage Diff @@
## development #4480 +/- ##
===============================================
- Coverage 22.28% 22.26% -0.02%
===============================================
Files 469 470 +1
Lines 4950 4958 +8
Branches 6 6
===============================================
+ Hits 1103 1104 +1
- Misses 3846 3853 +7
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side!!
It isn't even complete yet 🤷♂️ |
Means, your approach going in right direction.... |
There is no approach. I have literally just changed let to const |
13bb9dd
to
885edd7
Compare
Issues
======
- Added 4
Complexity increasing per file
==============================
- app/utils/text.ts 1
- app/components/forms/wizard/attendee-step.js 1
Complexity decreasing per file
==============================
+ app/models/custom-form.js -1
See the complete overview on Codacy |
export function slugify(string: string, sep: string = '-'): string { | ||
return string.toLowerCase() | ||
.replace(/[^\w\s-]/g, '') // remove non-word [a-z0-9_], non-whitespace, non-hyphen characters | ||
.replace(/[\s_-]+/g, sep) // swap any length of whitespace, underscore, hyphen characters with a single - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 4 spaces but found 8.
@@ -0,0 +1,6 @@ | |||
export function slugify(string: string, sep: string = '-'): string { | |||
return string.toLowerCase() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 2 spaces but found 4.
@@ -0,0 +1,6 @@ | |||
export function slugify(string: string, sep: string = '-'): string { | |||
return string.toLowerCase() | |||
.replace(/[^\w\s-]/g, '') // remove non-word [a-z0-9_], non-whitespace, non-hyphen characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 4 spaces but found 8.
return string.toLowerCase() | ||
.replace(/[^\w\s-]/g, '') // remove non-word [a-z0-9_], non-whitespace, non-hyphen characters | ||
.replace(/[\s_-]+/g, sep) // swap any length of whitespace, underscore, hyphen characters with a single - | ||
.replace(/^-+|-+$/g, ''); // remove leading, trailing - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 4 spaces but found 8.
Fixes #3199