Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add attendee custom form option #4480

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jun 20, 2020

Fixes #3199

@vercel
Copy link

vercel bot commented Jun 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/300rd8hh1
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-attendee-custom-form.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #4480 into development will decrease coverage by 0.01%.
The diff coverage is 5.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4480      +/-   ##
===============================================
- Coverage        22.28%   22.26%   -0.02%     
===============================================
  Files              469      470       +1     
  Lines             4950     4958       +8     
  Branches             6        6              
===============================================
+ Hits              1103     1104       +1     
- Misses            3846     3853       +7     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/models/custom-form.js 0.00% <0.00%> (ø)
app/routes/events/view/edit/attendee.js 0.00% <0.00%> (ø)
app/routes/orders/new.js 0.00% <ø> (ø)
app/utils/text.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da88f80...9444860. Read the comment docs.

sparsh-99
sparsh-99 previously approved these changes Jun 28, 2020
Copy link

@sparsh-99 sparsh-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side!!

@iamareebjamal
Copy link
Member Author

It isn't even complete yet 🤷‍♂️

@sparsh-99
Copy link

Means, your approach going in right direction....

@iamareebjamal
Copy link
Member Author

There is no approach. I have literally just changed let to const

@iamareebjamal iamareebjamal changed the title wip: Add attendee custom form option feat: Add attendee custom form option Jun 29, 2020
@auto-label auto-label bot added the feature label Jun 29, 2020
@iamareebjamal iamareebjamal merged commit 554e64e into fossasia:development Jun 29, 2020
@iamareebjamal iamareebjamal deleted the attendee-custom-form branch June 29, 2020 20:59
@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

Complexity increasing per file
==============================
- app/utils/text.ts  1
- app/components/forms/wizard/attendee-step.js  1
         

Complexity decreasing per file
==============================
+ app/models/custom-form.js  -1
         

See the complete overview on Codacy

export function slugify(string: string, sep: string = '-'): string {
return string.toLowerCase()
.replace(/[^\w\s-]/g, '') // remove non-word [a-z0-9_], non-whitespace, non-hyphen characters
.replace(/[\s_-]+/g, sep) // swap any length of whitespace, underscore, hyphen characters with a single -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,6 @@
export function slugify(string: string, sep: string = '-'): string {
return string.toLowerCase()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,6 @@
export function slugify(string: string, sep: string = '-'): string {
return string.toLowerCase()
.replace(/[^\w\s-]/g, '') // remove non-word [a-z0-9_], non-whitespace, non-hyphen characters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return string.toLowerCase()
.replace(/[^\w\s-]/g, '') // remove non-word [a-z0-9_], non-whitespace, non-hyphen characters
.replace(/[\s_-]+/g, sep) // swap any length of whitespace, underscore, hyphen characters with a single -
.replace(/^-+|-+$/g, ''); // remove leading, trailing -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step 2 : Allow addition of custom fields in the attendee-form
3 participants