Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Only enable sentry for non dummy DSN #4393

Merged
merged 1 commit into from
May 20, 2020
Merged

chore: Only enable sentry for non dummy DSN #4393

merged 1 commit into from
May 20, 2020

Conversation

iamareebjamal
Copy link
Member

No description provided.

@auto-label auto-label bot added the chore label May 20, 2020
@vercel
Copy link

vercel bot commented May 20, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/748dgrbad
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-sentry-disable.eventyay.now.sh

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 2

See the complete overview on Codacy

niranjan94
niranjan94 reviewed May 20, 2020
View reviewed changes
app/sentry.ts
// I don't know how to turn them off
if (!config.sentry.dsn.includes('dummy')) {

Sentry.init({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Expected indentation of 2 spaces but found 4.

niranjan94
niranjan94 reviewed May 20, 2020
View reviewed changes
app/sentry.ts
...event.extra,
adapter_errors: error.errors,
adapter_errors_json: JSON.stringify(error.errors)
Sentry.configureScope(function(scope) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Expected indentation of 2 spaces but found 4.

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #4393 into development will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4393      +/-   ##
===============================================
- Coverage        22.89%   22.62%   -0.27%     
===============================================
  Files              468      468              
  Lines             4941     4942       +1     
  Branches             5        6       +1     
===============================================
- Hits              1131     1118      -13     
- Misses            3808     3823      +15     
+ Partials             2        1       -1
Impacted Files Coverage Δ
app/sentry.ts 0.00% <0.00%> (-72.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad09367...c85d391. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 46e1842 into fossasia:development May 20, 2020
@iamareebjamal iamareebjamal deleted the sentry-disable branch May 20, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niranjan94 niranjan94 niranjan94 left review comments

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamareebjamal @niranjan94