Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change tracked condition to make computed work #4392

Merged
merged 1 commit into from
May 20, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented May 20, 2020

For some reason, on previous conditions, property was recomputed,
but UI wasn't updated. that only happened in production builds as well.
Changing the condition slightly as a workaround worked.

Upstream Issue: emberjs/ember.js#18988

Introduced in #4294 (f6bcfa1)

Fixes #4383

For some reason, on previous conditions, property was recomputed,
but UI wasn't updated. that only happened in production builds as well.
Changing the condition slightly as a workaround worked.

Upstream Issue: emberjs/ember.js#18988
@auto-label auto-label bot added the fix label May 20, 2020
@vercel
Copy link

vercel bot commented May 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6h3zoh7qx
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-tracked.eventyay.now.sh

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #4392 into development will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4392   +/-   ##
============================================
  Coverage        22.89%   22.89%           
============================================
  Files              468      468           
  Lines             4941     4941           
  Branches             5        5           
============================================
  Hits              1131     1131           
  Misses            3808     3808           
  Partials             2        2           
Impacted Files Coverage Δ
app/components/modals/user-delete-modal.js 0.00% <0.00%> (ø)
app/components/modals/event-delete-modal.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad09367...d899651. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 6d1e4ee into fossasia:development May 20, 2020
@iamareebjamal iamareebjamal deleted the tracked branch May 20, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin not able to edit or delete events
1 participant