Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misc bugs with ES6 getters #4387

Merged
merged 1 commit into from
May 22, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented May 19, 2020

No description provided.

@auto-label auto-label bot added the fix label May 19, 2020
@vercel
Copy link

vercel bot commented May 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/502568dyk
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-tax-event.eventyay.now.sh

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #4387 into development will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4387   +/-   ##
============================================
  Coverage        22.78%   22.78%           
============================================
  Files              468      468           
  Lines             4932     4932           
  Branches             5        5           
============================================
  Hits              1124     1124           
  Misses            3806     3806           
  Partials             2        2           
Impacted Files Coverage Δ
app/components/modals/tax-info-modal.js 22.22% <0.00%> (ø)
app/components/forms/wizard/basic-details-step.js 25.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978b7bc...7eab945. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: Tax addition after event creation fix: Misc bugs with ES6 getters May 22, 2020
@iamareebjamal iamareebjamal merged commit ed10529 into fossasia:development May 22, 2020
@iamareebjamal iamareebjamal deleted the tax-event branch May 22, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tax not working for created event
1 participant