Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ready event listener #4285

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Mar 29, 2020

Deprecated and spams the logs, and a completely empty callback!

There should be a lint for this

@vercel
Copy link

vercel bot commented Mar 29, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/115tel6bx
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-evented-ready.eventyay.now.sh

@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2020

This pull request introduces 1 alert when merging 9588bca into 1b452a8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@vercel vercel bot temporarily deployed to Preview March 29, 2020 00:35 Inactive
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #4285 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4285      +/-   ##
===============================================
- Coverage        21.88%   21.87%   -0.01%     
===============================================
  Files              461      461              
  Lines             4830     4831       +1     
  Branches             5        5              
===============================================
  Hits              1057     1057              
- Misses            3771     3772       +1     
  Partials             2        2
Impacted Files Coverage Δ
app/models/event.js 53.84% <ø> (ø) ⬆️
app/models/user.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b452a8...73d38d4. Read the comment docs.

@iamareebjamal iamareebjamal merged commit b1cd5f9 into fossasia:development Mar 29, 2020
@iamareebjamal iamareebjamal deleted the evented-ready branch March 29, 2020 00:52
Dishebh pushed a commit to Dishebh/open-event-frontend that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant