Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace croppie from bower to yarn #4257

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Mar 24, 2020

Fix for #3957

@vercel
Copy link

vercel bot commented Mar 24, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/4gt0od2qt
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-croppie-bower.eventyay.now.sh

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 6
           

See the complete overview on Codacy

rules: [
{
test: /\.css$/i,
use: ['style-loader', 'css-loader'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -48,29 +48,34 @@ module.exports = function(defaults) {
node: {
path: true // TODO: Remove after https://github.com/fossasia/open-event-frontend/issues/3956
},
externals: { jquery: 'jQuery' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
test: /\.css$/i,
use: ['style-loader', 'css-loader'],
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rules: [
{
test: /\.css$/i,
use: ['style-loader', 'css-loader'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module: {
rules: [
{
test: /\.css$/i,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test: /\.css$/i,
use: ['style-loader', 'css-loader'],
},
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #4257 into development will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4257   +/-   ##
============================================
  Coverage        21.88%   21.88%           
============================================
  Files              461      461           
  Lines             4830     4830           
  Branches             5        5           
============================================
  Hits              1057     1057           
  Misses            3771     3771           
  Partials             2        2           
Impacted Files Coverage Δ
app/components/modals/cropper-modal.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fe60a...0b71dab. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 2577ae3 into fossasia:development Mar 24, 2020
@iamareebjamal iamareebjamal deleted the croppie-bower branch March 24, 2020 22:25
Dishebh pushed a commit to Dishebh/open-event-frontend that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants