Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show "more call for speaker" button when appropriate #3610

Merged
merged 4 commits into from
Nov 13, 2019
Merged

fix: show "more call for speaker" button when appropriate #3610

merged 4 commits into from
Nov 13, 2019

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Nov 8, 2019

Fixes #3309
changes it propose
when there are less than or equal to three the "show more call for speaker " button will not be visible .
Screenshot from 2019-11-08 09-44-02

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Nov 8, 2019
uds5501
uds5501 previously approved these changes Nov 8, 2019
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

<div class="ui centered grid">
<div class="row">
{{#link-to "explore" (query-params cfs='open') class='ui blue button'}}{{t 'Show more calls for speakers'}}{{/link-to}}
{{#if (gt callForSpeakersEvents 3)}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the correct way callForSpeakersEvents returns the queried events not there number. Also, the comparison works here due to the Ember Arith Helper. I think a new property CFSeventsnumber should be used for comparison, I am also not sure if adding new property will be optimal or not. Hence, I will wait for the review of other mentors.

Copy link
Contributor Author

@maze-runnar maze-runnar Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude i understand what you are trying to say . So i changed the comparison here from {{#if (gt callForSpeakersEvents 3)}} to {{#if (gt callForSpeakersEvents.length 3)}}
now here is no reason to say it false in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check it .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 can you please check it again that it is also working fine ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the code ,as @kushthedude said .The previous was working fine but this gives a better understanding IMO.

@maze-runnar
Copy link
Contributor Author

@kushthedude can you please check it again , if it working fine ?

Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamareebjamal iamareebjamal changed the title fix:show "more call for speaker" button when more than three call for speaker events are there fix: show "more call for speaker" button when appropriate Nov 13, 2019
@iamareebjamal iamareebjamal merged commit 3283885 into fossasia:development Nov 13, 2019
@mariobehling
Copy link
Member

Thanks a lot for this PR. Please help to get some important issues out of the way in this project. We have labeled these issues here: https://github.com/fossasia/open-event-frontend/issues?q=is%3Aissue+is%3Aopen+label%3A%22Priority%3A+High%22 Our goal is to focus on these issues.

@maze-runnar
Copy link
Contributor Author

Ok @mariobehling i will trt to solve these issues .

@maze-runnar maze-runnar deleted the patch-8 branch December 12, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index Page: Add a condition for display of Show More Call of Speakers
5 participants