fix: Improve RegExp for URLs in Admin settings #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kushthedude Please review. |
uds5501
reviewed
Oct 16, 2019
| // user:pass authentication | ||
| + '(?:\\S+(?::\\S*)?@)?' | ||
| + '(?:' | ||
| // IP address exclusion | ||
| // private & local networks | ||
| + '(?!(?:10|127)(?:\\.\\d{1,3}){3})' | ||
| + '(?!(?:10)(?:\\.\\d{1,3}){3})' |
There was a problem hiding this comment.
any link/resource to verify the validity of this check?
There was a problem hiding this comment.
The Loopback IP address ranges from 127.0.0.0 to 127.255.255.255 and as per the Issue the Loopback address(es) should be valid for testing purposes so I removed the 127 address from the exclusion list as it was just excluding any addresses beginning with 10/127.
|
@reetam-nandi Can you please add a gif or video, showing reg-ex is working fine for all previous rules and new rules ? |
|
@kushthedude please check the following link which tests out the RegEx with necessary test cases. |
kushthedude
requested review from
abhinavk96,
mrsaicharan1 and
shreyanshdwivedi
shreyanshdwivedi
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3528
Short description of what this resolves:
RegExp for URLs improved to allow acceptance of localhost or 127.0.0.1 URLs in Admin settings.
Checklist
developmentbranch.