Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dropdown in Add Order section Fixed #3551

Merged
merged 3 commits into from
Nov 3, 2019
Merged

fix: Dropdown in Add Order section Fixed #3551

merged 3 commits into from
Nov 3, 2019

Conversation

amreshk005
Copy link
Contributor

Fixes #2797

Short description of what this resolves:

The dropdown is not bounded by the ticket table.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screen Shot 2019-10-10 at 4 35 03 PM

@amreshk005
Copy link
Contributor Author

@kushthedude I have fixed the issue.

Please take a look over it.

kushthedude
kushthedude reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Semantic PR Naming, else its LGTM

@amreshk005 amreshk005 changed the title UI issue in 'Add Order Form' Fixed UI issue: Dropdown in Add Order section Fixed Oct 16, 2019
@amreshk005
Copy link
Contributor Author

Use Semantic PR Naming, else its LGTM

@kushthedude I've changed the PR name.

snitin315
snitin315 reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@abhinavk96 abhinavk96 changed the title UI issue: Dropdown in Add Order section Fixed fix: Dropdown in Add Order section Fixed Nov 3, 2019
@auto-label auto-label bot added the fix label Nov 3, 2019
@abhinavk96 abhinavk96 merged commit 8614e4c into fossasia:development Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 left review comments

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@kushthedude kushthedude Awaiting requested review from kushthedude

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI issue in Add Order Form
4 participants
@amreshk005 @abhinavk96 @kushthedude @snitin315