fix: edit event accessible to user with event roles only #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyanshdwivedi
requested review from
abhinavk96,
kushthedude,
mrsaicharan1 and
uds5501
kushthedude
reviewed
Sep 1, 2019
| let event = this.modelFor('events.view'); | ||
| let { currentUser } = this.authManager; | ||
| if (!(currentUser.isAnAdmin || currentUser.email === event.owner.get('email') || event.organizers.includes(currentUser) | ||
| || event.coorganizers.includes(currentUser) || event.trackOrganizers.includes(currentUser) |
There was a problem hiding this comment.
@shreyanshdwivedi Just make sure if this hierarchy correct, I mean not every event role should have access to Edit Page. Confirm with @CosmicCoder96 or @mariobehling once, Else it is gtg.
There was a problem hiding this comment.
I think currently we are giving full access to all the event roles. @CosmicCoder96 is there any role which is needed to be removed?
Anupam-dagar
approved these changes
Sep 2, 2019
abhinavk96
approved these changes
Sep 2, 2019
|
@kushthedude @uds5501 @mrsaicharan1 please review |
uds5501
approved these changes
Sep 2, 2019
kushthedude
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3498
Short description of what this resolves:
Currently, any user can access edit page of the event.
Changes proposed in this pull request:
Checklist
developmentbranch.