fix: Enable sorting in admin users table #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushthedude
requested review from
abhinavk96,
mrsaicharan1,
shreyanshdwivedi and
uds5501
kushthedude
changed the title
abhinavk96
suggested changes
Aug 29, 2019
kushthedude
changed the title
|
@CosmicCoder96 Please Review |
|
All of them are working fine as all of them are defined in user schema.
…On Fri, 30 Aug, 2019, 22:09 Saicharan Reddy, ***@***.***> wrote:
***@***.**** commented on this pull request.
Provide a GIF of sorting these.. maybe that would be better IMO?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3488?email_source=notifications&email_token=AKQMTLSQHJ7DT433AXZEBX3QHFELNA5CNFSM4IRQNCVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDIQ72I#pullrequestreview-282136553>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKQMTLT344JSN22AQYKBZ53QHFELNANCNFSM4IRQNCVA>
.
|
abhinavk96
suggested changes
Aug 31, 2019
app/templates/components/ui-table/cell/admin/users/cell-first-name.hbs
Outdated
Show resolved
Hide resolved
app/templates/components/ui-table/cell/admin/users/cell-first-name.hbs
Outdated
Show resolved
Hide resolved
abhinavk96
suggested changes
Sep 2, 2019
app/templates/components/ui-table/cell/admin/users/cell-first-name.hbs
Outdated
Show resolved
Hide resolved
|
@CosmicCoder96 @mrsaicharan1 @shreyanshdwivedi I have tested all the actions on local regarding the change I have made of extraRecords and Record, Also the sorting is also working on the basis of firstName, Please Review. |
|
@kushthedude please add a gif of this fix maybe. It'll be better to review |
|
@kushthedude please update the PR description and add a gif so that this can be reviewed. Just want to make sure that everything is working fine on your side before pulling changes |
abhinavk96
approved these changes
Sep 19, 2019
5 tasks
|
@iamareebjamal Review Please |
|
I have little to no knowledge of frontend |
The PR is already approved by @CosmicCoder96 and since I need 3 reviews to self merge PR, You can bypass this procedure I think😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3487
Screenshot :