Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Design PayTM gateway modals #3447

Merged
merged 4 commits into from
Aug 22, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 20, 2019

Fixes #3446

Short description of what this resolves:

Add PayTM modal designs.
(actions will be linked once server PR has been completed)

Changes proposed in this pull request:

  • PayTM payment options modal created
    Screenshot from 2019-08-20 21-01-30

  • OTP entering modal prepared simultaneously
    Screenshot from 2019-08-20 21-04-13

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mrsaicharan1
Copy link
Member

For each modal, just keep adding screenshots of them to the description 🖼

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 20, 2019

@mrsaicharan1 Yes, I'll be doing that

@uds5501 uds5501 changed the title [wip]: Design and add paytm gateway modals feat: Design PayTM gateway modals Aug 20, 2019
@auto-label auto-label bot added the feature label Aug 20, 2019
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are going to add action in followup PR, this LGTM as a skeleton

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 21, 2019

@mrsaicharan1 @shreyanshdwivedi @kushthedude I have added the required validations in the modals. Please review now

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fossasia fossasia deleted a comment Aug 21, 2019
@fossasia fossasia deleted a comment Aug 21, 2019
@fossasia fossasia deleted a comment Aug 22, 2019
@kushthedude kushthedude merged commit 56f93b0 into fossasia:development Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Modal Designs for Paytm checkout
4 participants