-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introducing Ember Tables in Event Dashboard #3363
Conversation
@shreyanshdwivedi @CosmicCoder96 Need help, I can't figure out what's wrong but I am getting repetitive models and an incomplete table with error Uncaught Error: Assertion Failed: Cannot call get with 'count' on an undefined object. Please point what am I missing or doing wrong? |
@CosmicCoder96 Help Here! |
app/templates/components/events/view/overview/event-sponsors.hbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your problems will be solved if you just follow other tables.
app/templates/components/ui-table/cell/cell-sponsor-sanitize.hbs
Outdated
Show resolved
Hide resolved
@CosmicCoder96 It's still no good, Same rendering problem is coming again? |
app/templates/components/events/view/overview/event-sponsors.hbs
Outdated
Show resolved
Hide resolved
app/templates/components/events/view/overview/event-sponsors.hbs
Outdated
Show resolved
Hide resolved
@CosmicCoder96 Ready for final review. |
@kushthedude So search, sort and pagination works? |
Yes! |
@CosmicCoder96 Its good to be merged I think now |
@kushthedude I am aware that when I asked this
it wasn't working, I won't waste this much time on a PR ever again, you had basically again asked for a final review without testing anything again. |
You are right, they weren't when I asked for the review. |
Fixes #3362
Changes proposed in this pull request:
Model Tables
fromEvents Index Dashboard
Ember Tables
inSponsors Column
Checklist
development
branch.