Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introducing Ember Tables in Event Dashboard #3363

Merged
merged 21 commits into from
Aug 18, 2019
Merged

feat: Introducing Ember Tables in Event Dashboard #3363

merged 21 commits into from
Aug 18, 2019

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Aug 6, 2019

Fixes #3362

Changes proposed in this pull request:

  • Removed Model Tables from Events Index Dashboard
  • Introduced Ember Tables in Sponsors Column

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Aug 6, 2019
@kushthedude kushthedude changed the title feat: Introducing Ember Tables in Event Dashboard [WIP] feat: Introducing Ember Tables in Event Dashboard Aug 6, 2019
@auto-label auto-label bot removed the feature label Aug 6, 2019
@kushthedude
Copy link
Member Author

@shreyanshdwivedi @CosmicCoder96 Need help, I can't figure out what's wrong but I am getting repetitive models and an incomplete table with error

Uncaught Error: Assertion Failed: Cannot call get with 'count' on an undefined object.

image

Please point what am I missing or doing wrong?

@fossasia fossasia deleted a comment Aug 8, 2019
@fossasia fossasia deleted a comment Aug 11, 2019
@fossasia fossasia deleted a comment Aug 12, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 Help Here!

@fossasia fossasia deleted a comment Aug 12, 2019
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All your problems will be solved if you just follow other tables.

app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/routes/events/view/index.js Outdated Show resolved Hide resolved
app/routes/events/view/index.js Show resolved Hide resolved
app/routes/events/view/index.js Outdated Show resolved Hide resolved
app/routes/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Aug 14, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 It's still no good, Same rendering problem is coming again?

@fossasia fossasia deleted a comment Aug 15, 2019
app/routes/events/view/index.js Outdated Show resolved Hide resolved
app/routes/events/view/index.js Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Aug 15, 2019
app/routes/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Aug 17, 2019
app/controllers/events/view/index.js Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment Aug 18, 2019
@fossasia fossasia deleted a comment Aug 18, 2019
@kushthedude kushthedude changed the title [WIP] feat: Introducing Ember Tables in Event Dashboard feat: Introducing Ember Tables in Event Dashboard Aug 18, 2019
@auto-label auto-label bot added the feature label Aug 18, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 Ready for final review.

@abhinavk96
Copy link
Contributor

@kushthedude So search, sort and pagination works?

@kushthedude
Copy link
Member Author

@kushthedude So search, sort and pagination works?

Yes!

image

@kushthedude
Copy link
Member Author

@CosmicCoder96 Its good to be merged I think now

@fossasia fossasia deleted a comment Aug 18, 2019
@abhinavk96 abhinavk96 merged commit cca08f3 into fossasia:development Aug 18, 2019
@abhinavk96
Copy link
Contributor

abhinavk96 commented Aug 18, 2019

@kushthedude I am aware that when I asked this

@kushthedude So search, sort and pagination works?

it wasn't working, I won't waste this much time on a PR ever again, you had basically again asked for a final review without testing anything again.

@kushthedude
Copy link
Member Author

kushthedude commented Aug 18, 2019

@kushthedude I am aware that when I asked this

@kushthedude So search, sort and pagination works?

it wasn't working, I won't waste this much time on a PR ever again, you had basically again asked for a review without testing anything again.

You are right, they weren't when I asked for the review.
Wont repeat again.

@kushthedude kushthedude deleted the spon branch August 20, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Use Ember Table for sponsors
3 participants