Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrated payment component for event invoice #3351

Merged
merged 5 commits into from
Aug 17, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Aug 3, 2019

Fixes #3313
Server PR: fossasia/open-event-server#6296

Short description of what this resolves:

Integrates the paypal payment component with event invoice workflow.

https://drive.google.com/file/d/14Je8183BW4wgToQJCihp7C_k0MScbBjA/view?usp=sharing

Changes proposed in this pull request:

  • Replaces semantic UI button with existing PayPal-component with logic
  • Refactors component to work with event invoices

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Aug 3, 2019
@mrsaicharan1 mrsaicharan1 changed the title feat: integrared payment component for event invoice feat: integrated payment component for event invoice Aug 13, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@mrsaicharan1 mrsaicharan1 marked this pull request as ready for review August 14, 2019 09:45
@fossasia fossasia deleted a comment Aug 14, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@mrsaicharan1
Copy link
Member Author

As soon as this is merged, will be fixing the routing issue with the PayPal button. @shreyanshdwivedi @uds5501

@fossasia fossasia deleted a comment Aug 14, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@mrsaicharan1 mrsaicharan1 requested review from shreyanshdwivedi, niranjan94, abhinavk96 and uds5501 and removed request for niranjan94 August 14, 2019 16:24
@fossasia fossasia deleted a comment Aug 14, 2019
uds5501
uds5501 previously approved these changes Aug 14, 2019
@fossasia fossasia deleted a comment Aug 15, 2019
@fossasia fossasia deleted a comment Aug 16, 2019
@fossasia fossasia deleted a comment Aug 16, 2019
@fossasia fossasia deleted a comment Aug 16, 2019
@fossasia fossasia deleted a comment Aug 16, 2019
@mrsaicharan1 mrsaicharan1 requested a review from uds5501 August 16, 2019 11:00
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but server PR should be merged first. Then we can move forward with this

@fossasia fossasia deleted a comment Aug 16, 2019
@fossasia fossasia deleted a comment Aug 17, 2019
@kushthedude kushthedude requested review from kushthedude and abhinavk96 and removed request for abhinavk96 August 17, 2019 23:20
@kushthedude
Copy link
Member

@mrsaicharan1 Just a doubt, How can I create and test Event Invoices on my local?

@kushthedude kushthedude merged commit de0f59f into fossasia:development Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate PayPal component for Event Invoice Billing
4 participants