Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introducing Ember Tables in Admin/Messages #3340

Merged
merged 13 commits into from
Aug 11, 2019
Merged

feat: Introducing Ember Tables in Admin/Messages #3340

merged 13 commits into from
Aug 11, 2019

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Jul 31, 2019 •
edited
Loading

Fixes #3339

Screenshot

Screenshot 2019-08-02 at 6 32 50 PM

Short description of what this resolves:

  • Introducing Ember Tables in Admin/Messages

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jul 31, 2019
@kushthedude kushthedude marked this pull request as ready for review August 2, 2019 12:43
@fossasia fossasia deleted a comment Aug 2, 2019
@fossasia fossasia deleted a comment Aug 8, 2019
mrsaicharan1
mrsaicharan1 previously approved these changes Aug 8, 2019
View reviewed changes
@fossasia fossasia deleted a comment Aug 9, 2019
@fossasia fossasia deleted a comment Aug 9, 2019
uds5501
uds5501 previously approved these changes Aug 9, 2019
View reviewed changes
@kushthedude
Copy link
Member Author

@shreyanshdwivedi Please Review

@kushthedude kushthedude requested review from shreyanshdwivedi and removed request for abhinavk96 and shreyanshdwivedi August 10, 2019 09:37
@kushthedude kushthedude dismissed stale reviews from uds5501 and mrsaicharan1 via 628831d August 10, 2019 12:44
@kushthedude kushthedude requested review from mrsaicharan1, uds5501 and shreyanshdwivedi and removed request for shreyanshdwivedi August 10, 2019 12:47
@fossasia fossasia deleted a comment Aug 10, 2019
shreyanshdwivedi
shreyanshdwivedi approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

mrsaicharan1
mrsaicharan1 approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fossasia fossasia deleted a comment Aug 11, 2019
@kushthedude
Copy link
Member Author

@uds5501 Please Review

@kushthedude kushthedude merged commit 24455f9 into fossasia:development Aug 11, 2019
@kushthedude kushthedude deleted the table branch August 20, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uds5501 uds5501 uds5501 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Ember Tables in Admin/Messages
4 participants
@kushthedude @uds5501 @mrsaicharan1 @shreyanshdwivedi