Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Minor bugs and enhancements in admin area #3316

Merged
merged 2 commits into from
Jul 30, 2019
Merged

enh: Minor bugs and enhancements in admin area #3316

merged 2 commits into from
Jul 30, 2019

Conversation

kushthedude
Copy link
Member

Fixes #3315

Changes proposed in this pull request:

  • Added missing labels.
  • Added missing validations.
  • Fix the resizing of tables
  • Removed Extra Spaces in code file

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kushthedude it will be really helpful for others to review if u can add screenshots for before and after the PR :)

@kushthedude
Copy link
Member Author

@shreyanshdwivedi Actually this change required more than 3-4 ss that's why refrained from adding them.

@abhinavk96 abhinavk96 merged commit 121cc55 into fossasia:development Jul 30, 2019
@kushthedude kushthedude deleted the 10 branch December 19, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Area: Fix bugs arisen due to introduction of Ember-Tables
3 participants