fix: Wrong route defined in user accounts for admin #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaicharan1
approved these changes
Jun 25, 2019
abhinavk96
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
@prateekj117 just a query, can you please check if this change is not required here too - app/controllers/admin/users.js?
kushthedude
suggested changes
Jun 25, 2019
There was a problem hiding this comment.
@prateekj117 Can you please fix this also empty UI segment is getting displayed.
You also need to fix the routes in Admin/Users
mrsaicharan1
suggested changes
Jun 25, 2019
prateekj117
changed the title
|
@CosmicCoder96 Do I need to solve the issue pointed by @kushthedude in this issue itself? |
Anupam-dagar
approved these changes
Jun 25, 2019
|
@kushthedude I will open a separate issue for it. You can take that up. |
kushthedude
approved these changes
Jun 26, 2019
shreyanshdwivedi
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3181
Short description of what this resolves:
Wrong route is defined for Accounts Link in admin panel of users
Changes proposed in this pull request:
Defined the route properly so that admin can see user details
Checklist
developmentbranch.