Ane 1425 maven analysis hanging #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csasarak
requested changes
Feb 15, 2024
csasarak
approved these changes
Feb 15, 2024
| @@ -28,6 +28,75 @@ data MavenDependency = MavenDependency | |||
| mavenDependencyToDependency :: MavenDependency -> Dependency | |||
| mavenDependencyToDependency MavenDependency{..} = dependency | |||
|
|
|||
| -- | Filter all submodules (including their dependencies) that are not in `includedSubmoduleSet`. | |||
There was a problem hiding this comment.
This is really well written and makes the why and how really clear!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Maven analysis continues to run without ever stopping
Acceptance criteria
Ensure that maven analysis does not run forever.
Testing plan
Added a test case to include a cyclic graph in GraphingSpec.hs
Risks
Metrics
References
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.