Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding team and policy #44

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Adding team and policy #44

merged 5 commits into from
Aug 26, 2024

Conversation

saramaebee
Copy link
Contributor

@saramaebee saramaebee commented Aug 12, 2024

This adds the --policy and --team flags. I haven't updated the tests to include this because they require a new project in every case. We could set it up in a custom org and create a new project every time but I don't know if that's the right decision.

I did set this up in a dummy repo and confirmed that it's working.

@saramaebee saramaebee marked this pull request as ready for review August 12, 2024 17:23
@saramaebee saramaebee requested a review from a team as a code owner August 12, 2024 17:23
@saramaebee saramaebee requested review from spatten and removed request for a team August 12, 2024 17:23
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but other than that it looks great.

I agree that adding tests for this feature would be a larger lift and it's fine to leave it for now

src/index.ts Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@saramaebee saramaebee merged commit 464c3ea into main Aug 26, 2024
1 check passed
@saramaebee saramaebee deleted the sara-add-team-policy branch August 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants