Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR template. #43

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add a PR template. #43

merged 1 commit into from
Aug 14, 2024

Conversation

csasarak
Copy link
Contributor

@csasarak csasarak commented Aug 7, 2024

When I last made changes to this project I forgot to run yarn build, not realizing that I had to do it manually. This PR request template guides future programmers to make sure they do that.

@csasarak csasarak requested a review from a team as a code owner August 7, 2024 17:27
@csasarak csasarak requested review from zlav and JeffreyHuynh1 and removed request for a team August 7, 2024 17:27
@csasarak csasarak merged commit d61e2f7 into main Aug 14, 2024
1 check passed
@csasarak csasarak deleted the pr-template branch August 14, 2024 04:11
# Checklist

[ ] If I changed code, I ran `yarn build` and committed resulting changes.
[ ] I added an example exercising this PRs functionality to `.github/workflows/test.yml` or explained why it doesn't make sense to do so.
Copy link

@JeffreyHuynh1 JeffreyHuynh1 Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ ] I added an example exercising this PRs functionality to `.github/workflows/test.yml` or explained why it doesn't make sense to do so.
[ ] I added an example exercising this PR's functionality to `.github/workflows/test.yml` or explained why it doesn't make sense to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants