-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deauthentication not recognised by the client #919
Comments
I guess I experience a similar problem. On multiple clients (using firefox, chrome mobile) I only log in once. When I reopen the page, no login dialogue is shown and the error reads
If I'm using a private session, the login page is shown, and the client properly loads the feed items. I'm on master. This bug must have been introduced since 2.17 |
Yes, it was made worse here. I should have requested for it to be fixed, did not realize it would be so annoying. |
Pull Request #931 moved the authentication client side, which worsened the issue #919 by displaying error instead of the login form on opening selfoss when user did not log out and their session expired on the server. This patch redirects user to login form whenever client side session is registered and 403 Forbidden error is received. This is a temporary fix before offline support is merged.
Pull Request #931 moved the authentication client side, which worsened the issue #919 by displaying error instead of the login form on opening selfoss when user did not log out and their session expired on the server. This patch redirects user to login form whenever client side session is registered and 403 Forbidden error is received. This is a temporary fix before offline support is merged.
Still not working for me on the current dev version. |
Works for me. Can you detail how you make it fail and the corresponding error message? |
It is enough to delete the PHPSESSID cookie. After that I get the "No items loaded, reload?" message on the site and in the dev tools I can see calls on "https://url/?offset=0&itemsPerPage=50&search=&type=unread&tag=&source=&sourcesNav=false&ajax=true" that are answered with 403 unauthorized - "an error occured". |
If I login, delete the PHPSESSID cookie, click on a tag or a filter, I get a "your session has expired" red banner and the login screen, as expected. |
My config.ini for reference: |
Can you double check the version you are running and the js version loaded in your browser? Because I cannot find any failure on my setup. |
I switched back to 2.18 stable as a test, cleared all browser cache and testing with Chrome Dev tools with cache disabled. Same error. jQuery JavaScript Library v2.2.4 |
Please ensure latest js by deleting |
Still the same :-( |
Can you change |
Sure:
|
PHPSESSID
cookieAlternately, for 3., let selfoss synchronize the data, then a more precise error will be shown:
Ideally, selfoss would show message like “You have been signed out. Log in to continue.”
The text was updated successfully, but these errors were encountered: