Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: changed file ext to enable preprocessor #911

Merged
merged 1 commit into from
May 14, 2023
Merged

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented May 14, 2023

lowercase file extension was preventing the copmiler (gfortran)
to identify the existence of preprocessor definitions in the file
and turn on preproc parsing.

This caused issues downstream, during the creation of fpm PyPi
wheels.

Fixes #910

lowercase file extension was preventing the copmiler (gfortran)
to identify the existence of preprocessor definitions in the file
and turn on preproc parsing.

This caused issues downstream, during the creation of fpm PyPi
wheels.

Fixes #910
@gnikit gnikit requested review from perazz and awvwgk May 14, 2023 17:20
@gnikit
Copy link
Member Author

gnikit commented May 14, 2023

hack fix for PyPi wheels fortran-lang/fpm-on-wheels#11

Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @gnikit.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@awvwgk awvwgk merged commit 5a16564 into main May 14, 2023
@awvwgk awvwgk deleted the gnikit/issue910 branch May 14, 2023 21:13
henilp105 pushed a commit to henilp105/fpm that referenced this pull request Dec 11, 2023
lowercase file extension was preventing the copmiler (gfortran)
to identify the existence of preprocessor definitions in the file
and turn on preproc parsing.

This caused issues downstream, during the creation of fpm PyPi
wheels.

Fixes fortran-lang#910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: erroneous file extension for src/fpm/fpm_release.f90
3 participants