Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Setting up github #1

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Feature: Setting up github #1

merged 1 commit into from
Oct 21, 2023

Conversation

ani1311
Copy link
Collaborator

@ani1311 ani1311 commented Oct 20, 2023

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ldemailly ldemailly marked this pull request as ready for review October 21, 2023 02:03
@ldemailly
Copy link
Member

  Error: Error return value of `r.Wait` is not checked (errcheck)
  Error: Error return value of `w.Write` is not checked (errcheck)
  Error: Error return value of `w.Write` is not checked (errcheck)
  Error: Error return value of `server.Shutdown` is not checked (errcheck)
  Error: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)
  Error: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)

(and probably even more would show up once you copy fortio's .golangci.yml)

@wiardvanrij wiardvanrij merged commit c1cd535 into main Oct 21, 2023
3 of 4 checks passed
@wiardvanrij wiardvanrij deleted the setup-github branch October 21, 2023 21:10
@ldemailly
Copy link
Member

That's also too many I think

Screenshot 2023-10-21 at 2 10 30 PM

and... wiard merged despite failing tests :) let me update the settings for next time

@wiardvanrij
Copy link
Collaborator

Ahum, so this got merged while it shouldn't. My vscode did some magic, and this wasn't supposed to happen :+

ldemailly added a commit that referenced this pull request Oct 22, 2023
changes the logging and use "scli" shell

misc (many) linter fixes

fixing up #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants