Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcli fod release create: Improve handling of application attributes in --attrs option #604

Closed
rsenden opened this issue Sep 19, 2024 · 0 comments · Fixed by #605
Closed
Labels
bug Something isn't working

Comments

@rsenden
Copy link
Contributor

rsenden commented Sep 19, 2024

Current Behavior

Given a command like the following:

fcli fod release create ... --attrs AppAttribute=val1,RelAttr=val2

Fcli will update AppAttribute on the application, which is likely unexpected and unintended behavior. It is unlikely that anyone is explicitly passing application attributes on release creation, so probably not much of an issue right now.

However, at some point we may want to have the setup-release action also support automatically creating the application if it doesn't yet exist. We'd likely re-use the existing --attrs action parameter, allowing this parameter to be used to configure both application and release attributes. We'd then simply pass the value of the --attrs option to both fcli fod app create and fcli fod release create commands.

If the app doesn't exist yet, the fcli fod app create command would create both app and release with the given attributes. However, if the app exists but version doesn't, we wouldn't want the fcli fod release create command to update any existing application attributes.

Expected Behavior

On the fcli fod release create command, we should filter out any application attributes, including only release attributes in the release creation request.

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

@rsenden rsenden added the bug Something isn't working label Sep 19, 2024
kadraman pushed a commit to kadraman/fcli that referenced this issue Sep 20, 2024
…ibutes in --attrs option (fixes fortify#604)

chore: working `fcli fod action run setup-release`
rsenden pushed a commit that referenced this issue Sep 20, 2024
fix: `fcli fod release create`: Ignore application attributes if included in `--attrs` option (fixes #604)

fix: `fcli fod release update`: Ignore application attributes if included in `--attrs` option (fixes #604)

fix: `fcli fod app update`: Ignore release attributes if included in `--attrs` option (fixes #604)

chore: `fcli fod app create`: Allow both app & release attributes to be specified in `--attrs` option

chore: `setup-release` action: Add support for attributes & Aviator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant