Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcli ssc appversion-artifact download: response 500 returned when --no-include-source is used without --id #173

Closed
james-du1 opened this issue Dec 8, 2022 · 3 comments

Comments

@james-du1
Copy link

according to document of fcli tool
--no-include-sources, --id= are mutually exclusive (specify only one)
but IF --id is NOT included in the command, response 500 returned

in ssc, we can download the snapshot of the application as well as downloading each fpr that was uploaded to the application version, can we replicate the way SSC works so that the functions of fcli tool are aligned with SSC?

image

@rsenden
Copy link
Contributor

rsenden commented Dec 12, 2022

The --no-include-sources option is only applicable when downloading the latest application state for the given application version, not when downloading an artifact by id (since that will be the original artifact), hence those two options are mutually exclusive. Question is why this results in an HTTP 500 error; can you check/share the SSC logs?

@MikeTheSnowman
Copy link
Collaborator

Hey @rsenden , I think James might be correct in that the --id and --no-include-sources options needing to not be mutually exclusive. Looking at the SSC web UI, it appears that you can download previously uploaded artifacts with/without sources.
image

These are the API's that I'm seeing being invoked when trying to download an artifact with/without sources, versus downloading an "application version state" artifact with/without sources.
image

@rsenden
Copy link
Contributor

rsenden commented Dec 14, 2022

There was actually another bug in the download command, with application file downloads (no --id specified on command line) always failing and the --id option downloading the application file instead of the requested id due to inverted logic. Next push will fix this, and will also have the --no-include-sources option available for both raw FPR and application file downloads.

rsenden added a commit that referenced this issue Dec 14, 2022
…nloading application file

fix: `fcli ssc appversion-artifact download`: `--no-include-sources` now available for both application file and individual FPR download (fixes #173)
rsenden added a commit that referenced this issue Dec 14, 2022
…nloading application file

fix: `fcli ssc appversion-artifact download`: `--no-include-sources` now available for both application file and individual FPR download (fixes #173)
@github-actions github-actions bot mentioned this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants