Use computed properties in input helpers #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious...why? :) |
|
By the way, looks like TypeScript doesn't support computed properties microsoft/TypeScript#1811. It's not even on their roadmap yet, beyond "spec it out". So I'm going to close this. |
|
This PR is not a big deal. So don't worry about it. Looking at the produced code I see it does support computed properties. Maybe because we are using alpha TypeScript it has edgy features |
|
I would consider "supporting computed properties" as "recognizes and transpiles them" since at this point no one supports them outside of recent Firefox. I don't think we should change 3 lines to 2 lines when those 2 lines aren't supported by anyone unless we're going to transpile it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.