fix(temporal): continue a new when terminating workflows #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having a connector with lots of data, we can have lots of workflows. When uninstalling, we will go through the workflows to terminated them, but we will maybe exceed the history size or length of a worfklow. This commits adds two things: the termination of workflows in background and continue a new if we reach the limits
paul-nicolas
force-pushed
the
fix/temporal-terminate-workflows
branch
from
61fddcf to
067a375
Compare
laouji
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a connector with lots of data, we can have lots of workflows. When uninstalling, we will go through the workflows to terminated them, but we will maybe exceed the history size or length of a worfklow.
This PR adds two things: the termination of workflows in background and continue a new if we reach the limits