feat(currenclycloud): improve loops and add tests #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-nicolas
force-pushed
the
feat/payments-currency-cloud-tests
branch
3 times, most recently
from
d173585 to
9a57bea
Compare
paul-nicolas
force-pushed
the
feat/payments-currency-cloud-tests
branch
from
d0ab550 to
15db298
Compare
laouji
reviewed
Oct 2, 2024
| return fmt.Sprintf("%s/%s", c.endpoint, fmt.Sprintf(path, args...)) | ||
| } | ||
|
|
||
| const DevAPIEndpoint = "https://devapi.currencycloud.com" | ||
|
|
||
| func newHTTPClient() *http.Client { | ||
| func NewHTTPClient() *http.Client { |
There was a problem hiding this comment.
I'm surprised the linter isn't saying anything but this appears to be unused now that you removed the authentication call at install time.
laouji
reviewed
Oct 2, 2024
internal/connectors/plugins/public/currencycloud/client/auth.go
Outdated
Show resolved
Hide resolved
laouji
reviewed
Oct 2, 2024
laouji
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ENG-1426
Fixes ENG-1433