feat(payments): wrap Stripe SDK errors so we can detect http client-s…

…ide issues and assign an appropriate gpc error code

internal/connectors/plugins/public/stripe/client/accounts.go

@@ -22,7 +22,7 @@ func (c *client) GetAccounts(
 		var oldest interface{}
 		oldest, timeline, hasMore, err = scanForOldest(timeline, pageSize, func(params stripe.ListParams) (stripe.ListContainer, error) {
 			itr := c.accountClient.List(&stripe.AccountListParams{ListParams: params})
-			return itr.AccountList(), itr.Err()
+			return itr.AccountList(), wrapSDKErr(itr.Err())
 		})
 		if err != nil {
 			return results, timeline, false, err
@@ -43,5 +43,5 @@ func (c *client) GetAccounts(
 	itr := c.accountClient.List(&stripe.AccountListParams{ListParams: filters})
 	results = append(results, itr.AccountList().Data...)
 	timeline.LatestID = results[len(results)-1].ID
-	return results, timeline, itr.AccountList().ListMeta.HasMore, itr.Err()
+	return results, timeline, itr.AccountList().ListMeta.HasMore, wrapSDKErr(itr.Err())
 }

internal/connectors/plugins/public/stripe/client/balances.go

@@ -18,6 +18,7 @@ func (c *client) GetAccountBalances(ctx context.Context, accountID string) (*str
 	}
 
 	balance, err := c.balanceClient.Get(&stripe.BalanceParams{Params: filters})
+	err = wrapSDKErr(err)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get stripe balance: %w", err)
 	}

internal/connectors/plugins/public/stripe/client/client.go

@@ -2,7 +2,9 @@ package client
 
 import (
 	"context"
+	"fmt"
 
+	"github.com/formancehq/payments/internal/connectors/httpwrapper"
 	"github.com/stripe/stripe-go/v79"
 	"github.com/stripe/stripe-go/v79/account"
 	"github.com/stripe/stripe-go/v79/balance"
@@ -42,3 +44,23 @@ func limit(wanted int64, have int) *int64 {
 	needed := wanted - int64(have)
 	return &needed
 }
+
+// wrap a public error for cases that we don't want to retry
+// so that activities can classify this error for temporal
+func wrapSDKErr(err error) error {
+	if err == nil {
+		return nil
+	}
+
+	stripeErr, ok := err.(*stripe.Error)
+	if !ok {
+		return err
+	}
+
+	switch stripeErr.Type {
+	case stripe.ErrorTypeInvalidRequest, stripe.ErrorTypeIdempotency:
+		return fmt.Errorf("%w: %w", httpwrapper.ErrStatusCodeClientError, err)
+
+	}
+	return err
+}

internal/connectors/plugins/public/stripe/client/external_accounts.go

@@ -31,7 +31,7 @@ func (c *client) GetExternalAccounts(
 				Account:    &accountID,
 				ListParams: params,
 			})
-			return itr.BankAccountList(), itr.Err()
+			return itr.BankAccountList(), wrapSDKErr(itr.Err())
 		})
 		if err != nil {
 			return results, timeline, false, err
@@ -51,7 +51,7 @@ func (c *client) GetExternalAccounts(
 		},
 	})
 	if err := itr.Err(); err != nil {
-		return nil, timeline, false, handleError(itr.Iter)
+		return nil, timeline, false, wrapSDKErr(err)
 	}
 	results = append(results, itr.BankAccountList().Data...)
 	timeline.LatestID = results[len(results)-1].ID

internal/connectors/plugins/public/stripe/client/payments.go

@@ -39,7 +39,7 @@ func (c *client) GetPayments(
 			transactionParams := &stripe.BalanceTransactionListParams{ListParams: params}
 			expandBalanceTransactionParams(transactionParams)
 			itr := c.balanceTransactionClient.List(transactionParams)
-			return itr.BalanceTransactionList(), itr.Err()
+			return itr.BalanceTransactionList(), wrapSDKErr(itr.Err())
 		})
 		if err != nil {
 			return results, timeline, false, err
@@ -69,7 +69,7 @@ func (c *client) GetPayments(
 	itr := c.balanceTransactionClient.List(params)
 	results = append(results, itr.BalanceTransactionList().Data...)
 	timeline.LatestID = results[len(results)-1].ID
-	return results, timeline, itr.BalanceTransactionList().ListMeta.HasMore, itr.Err()
+	return results, timeline, itr.BalanceTransactionList().ListMeta.HasMore, wrapSDKErr(itr.Err())
 }
 
 func expandBalanceTransactionParams(params *stripe.BalanceTransactionListParams) {