feat: trimmed zero postings

formancehq · Dec 6, 2024 · 90f330d · 90f330d
1 parent 661c6a1
commit 90f330d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/internal/interpreter/interpreter.go b/internal/interpreter/interpreter.go
@@ -618,6 +618,10 @@ func (s *programState) receiveFrom(destination parser.Destination, amount *big.I
 		remainingAmount := new(big.Int).Set(amount)
 
 		handler := func(keptOrDest parser.KeptOrDestination, amountToReceive *big.Int) InterpreterError {
+			if amountToReceive.Cmp(big.NewInt(0)) == 0 {
+				return nil
+			}
+
 			err := s.receiveFromKeptOrDest(keptOrDest, amountToReceive)
 			if err != nil {
 				return err

diff --git a/internal/interpreter/interpreter_test.go b/internal/interpreter/interpreter_test.go
@@ -2659,6 +2659,30 @@ func TestZeroPostings(t *testing.T) {
 	test(t, tc)
 }
 
+func TestZeroPostingsDestination(t *testing.T) {
+	tc := NewTestCase()
+	tc.compile(t, `
+	send [COIN 100] (
+		source = @world
+		destination = {
+			max [COIN 0] to @d1
+			remaining to @d2
+		}
+	)
+	`)
+	tc.expected = CaseResult{
+		Postings: []machine.Posting{
+			{
+				"world",
+				"d2",
+				big.NewInt(100),
+				"COIN",
+			},
+		},
+	}
+	test(t, tc)
+}
+
 func TestUnboundedOverdraftWhenNotEnoughFunds(t *testing.T) {
 	tc := NewTestCase()
 	tc.setBalance("users:2345:main", "USD/2", 8000)