-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share PGSQL connection pool between ledgers. #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 54.51% 54.90% +0.38%
==========================================
Files 38 38
Lines 1781 1794 +13
==========================================
+ Hits 971 985 +14
+ Misses 714 712 -2
- Partials 96 97 +1
Continue to review full report at Codecov.
|
gfyrag
force-pushed
the
feature/pgsql-shared-connection-pool
branch
from
December 9, 2021 07:58
c2fa1fb
to
1db8bca
Compare
To do this, we introduce a storage.Driver interface between the storage.Factory and the Store implementations. This interface is in charge of initializing the connection to the underlying database (in case of PGSQL, create the pool) and create the underlying stores for ledgers.
altitude
reviewed
Dec 9, 2021
flemzord
approved these changes
Dec 9, 2021
altitude
approved these changes
Dec 16, 2021
gfyrag
added a commit
that referenced
this pull request
Feb 23, 2023
flemzord
pushed a commit
that referenced
this pull request
Mar 27, 2023
flemzord
pushed a commit
that referenced
this pull request
Apr 18, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 20, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this, we introduce a storage.Driver interface between the storage.Factory and the Store implementations.
This interface is in charge of initializing the connection to the underlying database (in case of PGSQL, create the pool) and create the underlying stores for ledgers.