feat: optimize volumes endpoint when not using pit

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve modifications to the internal/storage/ledger/volumes.go file. Key updates include a reordering of the import statements and a restructuring of the selectVolumes function to enhance query logic based on time filters and feature checks. Additionally, the UpdateVolumes method has streamlined error handling by directly returning results from error resolution. Overall, the functionality remains intact while improving control flow and error management.

Changes

File	Change Summary
internal/storage/ledger/volumes.go	- Reordered import statements. - Restructured selectVolumes function to modify query logic based on time filters and FeatureMovesHistory. - Streamlined error handling in UpdateVolumes method.

Poem

In the ledger where volumes play,
A rabbit hops through night and day.
With features checked and queries neat,
The data flows, a rhythmic beat.
Errors resolved, all clear and bright,
Hooray for changes, what a delight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

internal/storage/ledger/volumes.go (1)

105-143: Consider refactoring to simplify complex conditional logic

The selectVolumes function contains multiple nested conditions that handle different scenarios. Refactoring the query construction into separate helper functions could improve readability and maintainability.

For example, you could create helper functions like buildVolumesQueryWithoutTimeFilters and buildVolumesQueryWithTimeFilters to encapsulate the logic for each case.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5814540 and 41d79e6.

📒 Files selected for processing (1)

• internal/storage/ledger/volumes.go (2 hunks)

🔇 Additional comments (7)

internal/storage/ledger/volumes.go (7)

9-9: Import usage of the features package is appropriate

The features package is correctly imported and utilized in the code, ensuring feature checks are performed where necessary.

---

105-105: Declaration of selectVolumes outside conditionals enhances clarity

Declaring selectVolumes before the conditional blocks improves code readability and prevents scope-related issues.

---

107-116: Efficient querying when time filters are not provided

When pit and oot are not provided, selecting volumes directly from the accounts_volumes table optimizes performance by avoiding unnecessary computations.

---

117-119: Proper feature check for FeatureMovesHistory when time filters are used

Ensuring that the FeatureMovesHistory feature is enabled when pit or oot are provided prevents unauthorized access to historical data and maintains system integrity.

---

121-125: Dynamic selection of date filter column enhances flexibility

Assigning dateFilterColumn based on useInsertionDate allows the query to adapt to different filtering requirements, making the function more versatile.

---

126-136: Comprehensive aggregation from the moves table

Constructing the query to aggregate inputs, outputs, and balances from the moves table accurately reflects account activities over time when time filters are applied.

---

137-143: Correct application of time filters in the query

The conditions for pit and oot correctly modify the query to filter records based on the provided timestamps, ensuring accurate retrieval of data within the specified time range.