Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split execution path to avoid breaking changes #427

Merged
merged 11 commits into from
Feb 6, 2023

Conversation

antoinegelloz
Copy link
Contributor

  • POST /transactions only containing postings with zero amount should be inserted without error
  • POST /transactions with script only containing sends with zero amount should return "transaction has no postings" error

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #427 (550e2fa) into main (871d69e) will decrease coverage by 0.39%.
The diff coverage is 71.63%.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   69.38%   69.00%   -0.39%     
==========================================
  Files          95       95              
  Lines        6522     6513       -9     
==========================================
- Hits         4525     4494      -31     
- Misses       1613     1632      +19     
- Partials      384      387       +3     
Impacted Files Coverage Δ
pkg/core/asset.go 100.00% <ø> (ø)
pkg/ledger/execute_script.go 67.55% <67.55%> (ø)
pkg/ledger/execute_txsdata.go 75.96% <75.96%> (ø)
pkg/api/controllers/script_controller.go 87.50% <100.00%> (-0.31%) ⬇️
pkg/api/controllers/transaction_controller.go 70.83% <100.00%> (-0.19%) ⬇️
pkg/ledger/ledger.go 70.17% <100.00%> (-0.26%) ⬇️
pkg/analytics/segment.go 54.07% <0.00%> (-3.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.golangci.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants