Add pre transactions balance to the log #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 66.05% 67.16% +1.11%
==========================================
Files 71 72 +1
Lines 3591 3816 +225
==========================================
+ Hits 2372 2563 +191
- Misses 976 1001 +25
- Partials 243 252 +9
Continue to review full report at Codecov.
|
gfyrag
force-pushed
the
feature/num-495-add-pre-transactions-balance-to-the-log
branch
2 times, most recently
from
6ab3a8f to
e775b93
Compare
…" table. Both are written on api response and bus events.
gfyrag
force-pushed
the
feature/num-495-add-pre-transactions-balance-to-the-log
branch
from
e775b93 to
50987cf
Compare
antoinegelloz
suggested changes
Jun 13, 2022
pkg/ledger/ledger.go
Outdated
| aggregatedVolumes := core.AggregatedVolumes{} | ||
| volumeAggregator := NewVolumeAggregator(l.store) | ||
|
|
||
| generatedTxs := make([]core.Transaction, 0) | ||
| accounts := make(map[string]core.Account, 0) | ||
| logs := make([]core.Log, 0) |
There was a problem hiding this comment.
Just as the transactions were renamed to generatedTxs, I would also rename it to generatedLogs.
pkg/ledger/volume_agg.go
Outdated
| agg *VolumeAggregator | ||
| postVolumes core.AggregatedVolumes | ||
| preVolumes core.AggregatedVolumes | ||
| previous *TransactionVolumeAggregator |
There was a problem hiding this comment.
Suggested change
| previous *TransactionVolumeAggregator | |
| previousTx *TransactionVolumeAggregator |
Co-authored-by: Antoine Gelloz <[email protected]>
Co-authored-by: Antoine Gelloz <[email protected]>
antoinegelloz
approved these changes
Jun 14, 2022
gfyrag
deleted the
feature/num-495-add-pre-transactions-balance-to-the-log
branch
altitude
changed the title
flemzord
pushed a commit
that referenced
this pull request
Jun 7, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 20, 2023
flemzord
pushed a commit
that referenced
this pull request
Dec 4, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.