Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GET /_health endpoint #170

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Mar 15, 2022

Return 500 if not ok and 200 if ok.
The response will contains a map of string/string for each checks.
The value is 'OK' if the check passed, otherwise, is is the error.

@gfyrag gfyrag requested a review from a team as a code owner March 15, 2022 14:34
@gfyrag gfyrag requested a review from flemzord March 15, 2022 14:34
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #170 (60c4548) into main (3c42a79) will increase coverage by 0.25%.
The diff coverage is 87.50%.

❗ Current head 60c4548 differs from pull request most recent head 7204f54. Consider uploading reports for the commit 7204f54 to get more accurate results

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   73.97%   74.22%   +0.25%     
==========================================
  Files          76       79       +3     
  Lines        3093     3147      +54     
==========================================
+ Hits         2288     2336      +48     
- Misses        634      640       +6     
  Partials      171      171              
Impacted Files Coverage Δ
internal/pgtesting/testing.go 86.95% <ø> (ø)
pkg/storage/sqlstorage/driver.go 71.83% <0.00%> (-3.56%) ⬇️
pkg/api/controllers/health_controller.go 93.54% <93.54%> (ø)
pkg/api/controllers/controllers.go 100.00% <100.00%> (ø)
pkg/api/internal/testing.go 98.26% <100.00%> (ø)
pkg/api/routes/routes.go 100.00% <100.00%> (ø)
pkg/health/health.go 100.00% <100.00%> (ø)
pkg/health/module.go 100.00% <100.00%> (ø)
pkg/ledger/resolver.go 85.00% <100.00%> (ø)
pkg/ledgertesting/db.go 88.09% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19639d1...7204f54. Read the comment docs.

@gfyrag gfyrag force-pushed the feature/num-336-ledger-add-health-endpoint branch from 28ff9a8 to 4382afb Compare March 15, 2022 21:16
Return 500 if not ok and 200 if ok.
The response will contains a map of string/string for each checks.
The value is 'OK' if the check passed, otherwise, is is the error.
@gfyrag gfyrag force-pushed the feature/num-336-ledger-add-health-endpoint branch from 4382afb to 7204f54 Compare March 16, 2022 07:38
@gfyrag gfyrag merged commit 54d09f5 into main Mar 16, 2022
@gfyrag gfyrag deleted the feature/num-336-ledger-add-health-endpoint branch March 16, 2022 07:56
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants