Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sharedlogging package from go-libs #166

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Mar 1, 2022

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner March 1, 2022 13:13
@gfyrag gfyrag requested a review from flemzord March 1, 2022 13:13
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #166 (3020ef0) into main (475b7ac) will increase coverage by 0.00%.
The diff coverage is 73.68%.

❗ Current head 3020ef0 differs from pull request most recent head 28f0a9d. Consider uploading reports for the commit 28f0a9d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   72.82%   72.83%           
=======================================
  Files          78       76    -2     
  Lines        3091     3011   -80     
=======================================
- Hits         2251     2193   -58     
+ Misses        670      648   -22     
  Partials      170      170           
Impacted Files Coverage Δ
pkg/api/internal/testing.go 98.26% <ø> (-0.02%) ⬇️
pkg/api/middlewares/ledger_middleware.go 61.11% <0.00%> (-2.05%) ⬇️
pkg/api/routes/routes.go 100.00% <ø> (ø)
pkg/config/config.go 0.00% <0.00%> (ø)
pkg/ledger/resolver.go 88.00% <ø> (-1.10%) ⬇️
pkg/storage/remember_config.go 0.00% <0.00%> (ø)
pkg/api/controllers/script_controller.go 90.24% <66.66%> (-0.24%) ⬇️
pkg/storage/sqlstorage/store.go 76.81% <85.71%> (-0.34%) ⬇️
cmd/container.go 82.65% <100.00%> (+0.17%) ⬆️
pkg/api/middlewares/log_middleware.go 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1d4fa...28f0a9d. Read the comment docs.

@gfyrag gfyrag force-pushed the feature/num-415-ledger-use-sharedlogging-package branch from fa22a5a to 28f0a9d Compare March 4, 2022 09:33
@gfyrag gfyrag merged commit 2c3d5f7 into main Mar 4, 2022
@gfyrag gfyrag deleted the feature/num-415-ledger-use-sharedlogging-package branch March 4, 2022 09:45
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants