Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make opentelemetry batching configurable #162

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Feb 18, 2022

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner February 18, 2022 16:05
@gfyrag gfyrag requested a review from altitude February 18, 2022 16:05
@gfyrag gfyrag force-pushed the feature/num-357-ledger-opentelemetry-config branch 2 times, most recently from 163c6cb to 2c8b39a Compare February 18, 2022 16:49
@gfyrag gfyrag requested a review from flemzord as a code owner February 18, 2022 16:49
@gfyrag gfyrag force-pushed the feature/num-357-ledger-opentelemetry-config branch 3 times, most recently from ee41b58 to c2b5df0 Compare February 18, 2022 17:06
@gfyrag gfyrag force-pushed the feature/num-357-ledger-opentelemetry-config branch from c2b5df0 to 89af415 Compare February 18, 2022 17:10
@gfyrag gfyrag force-pushed the feature/num-357-ledger-opentelemetry-config branch from 89af415 to 1a78fb5 Compare February 18, 2022 17:17
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #162 (99dd76a) into main (3020ef0) will increase coverage by 0.08%.
The diff coverage is 97.29%.

❗ Current head 99dd76a differs from pull request most recent head 087fcd1. Consider uploading reports for the commit 087fcd1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   72.83%   72.91%   +0.08%     
==========================================
  Files          76       76              
  Lines        3011     3035      +24     
==========================================
+ Hits         2193     2213      +20     
- Misses        648      660      +12     
+ Partials      170      162       -8     
Impacted Files Coverage Δ
pkg/opentelemetry/opentelemetrytraces/resource.go 100.00% <ø> (ø)
pkg/opentelemetry/opentelemetrytraces/traces.go 82.10% <95.83%> (+3.72%) ⬆️
cmd/container.go 82.65% <100.00%> (ø)
cmd/root.go 86.30% <100.00%> (+0.19%) ⬆️
pkg/ledgertesting/testing.go 86.95% <100.00%> (+13.04%) ⬆️
...pentelemetry/opentelemetrytraces/jaegerexporter.go 83.33% <100.00%> (+8.33%) ⬆️
.../opentelemetry/opentelemetrytraces/otlpexporter.go 100.00% <100.00%> (+9.30%) ⬆️
...pentelemetry/opentelemetrytraces/stdoutexporter.go 100.00% <100.00%> (+19.04%) ⬆️
pkg/storage/sqlstorage/store.go 73.07% <0.00%> (-3.74%) ⬇️
pkg/api/controllers/base_controller.go 72.50% <0.00%> (-0.68%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3d5f7...087fcd1. Read the comment docs.

@gfyrag gfyrag changed the title Make opentelemetry batching configurable feat: Make opentelemetry batching configurable Feb 18, 2022
@gfyrag gfyrag force-pushed the feature/num-357-ledger-opentelemetry-config branch from 1a78fb5 to 0330752 Compare March 1, 2022 11:03
gfyrag added 4 commits March 4, 2022 10:45
The default will not batch anything. To enable, use flag --otel-traces-batch.
Also the noop exporter has been removed since opentelemetry support is disabled by default.
@gfyrag gfyrag force-pushed the feature/num-357-ledger-opentelemetry-config branch from 0330752 to 087fcd1 Compare March 4, 2022 09:46
@gfyrag gfyrag merged commit 0b5a1c2 into main Mar 4, 2022
@gfyrag gfyrag deleted the feature/num-357-ledger-opentelemetry-config branch March 4, 2022 10:17
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants