Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/num 255 error handling on ledger #123

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jan 10, 2022

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner January 10, 2022 10:17
@gfyrag gfyrag requested a review from djimnz January 10, 2022 10:17
Copy link
Member

@altitude altitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@gfyrag gfyrag merged commit 7b9a819 into main Jan 10, 2022
@gfyrag gfyrag deleted the feature/num-255-error-handling-on-ledger branch January 10, 2022 19:19
flemzord pushed a commit that referenced this pull request Jun 7, 2023
flemzord pushed a commit that referenced this pull request Sep 20, 2023
flemzord pushed a commit that referenced this pull request Dec 4, 2023
flemzord pushed a commit that referenced this pull request Sep 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2025
* feat: Add Flake

* ci: Rework tests

- Add ginkgo to the list of dependencies in flake.nix
- Remove unnecessary CACHE directives in Earthfile
- Simplify 'compile' section in Earthfile
- Simplify 'tests' section in Earthfile
- Simplify 'lint' section in Earthfile
- Simplify 'pre-commit' section in Earthfile
- Simplify 'pre-commit-nix' section in Earthfile
- Simplify 'tidy' section in Earthfile
- Simplify 'export-docs-events' section in Earthfile

feat/nix

* ci: Rework config

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix'
hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix'
hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix'
hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix'
hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix'
hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added 'pre-commit-nix'
hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added
'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix)

* ci: Rework config

Reworked config to use 'nix develop' with 'earthly' command. Added
'pre-commit-nix' hook. Removed unnecessary flags and secrets. (feat/nix)

* feat(ledger): optimize release script in Earthfile (issue #123)

* Add .envrc and update .gitignore to track it

Added a new .envrc file with configuration for direnv and updated .gitignore to include .envrc while still ignoring .env files. This ensures proper local environment setup using direnv without accidentally committing sensitive .env files.

* Add missing `isgomock` struct to mock test files

This change ensures all mock test files include the `isgomock` struct, standardizing the structure of generated mocks. This addition aligns with gomock's conventions and facilitates internal consistency across mock definitions.

* chore: migrate from Earthly to Just for build and workflow automation

This change replaces Earthly with Just by removing Earthfiles and
introducing a Justfile. Benefits include streamlining the dependency
management, simplifying workflow automation, and improving build
process readability.

Build and CI workflows (e.g., pre-commit, tests, linting) have been
adapted to utilize Just commands, ensuring consistency across
development processes.

* build(workflow): update CI to simplify release commands

Replaced complex earthly-based release command with a `just` target in
the CI workflow for better maintainability. Added new `release`
commands to the Justfile for local, CI, and standard releases. This
streamlines the release process and enhances clarity.

* refactor: simplify and streamline build and lint processes

- Removed unused 'group' annotation in Justfile to enhance clarity.
- Consolidated COPY commands in Earthfile for better maintainability.
- Updated 'compile' stage in Earthfile to use 'sources' for consistency.

These changes reduce redundancy, improve readability, and ensure less
complexity in maintenance.

* fix(justfile): reorder pre-commit tasks for consistent execution flow

Reordered tasks in the pre-commit command to ensure `generate` and
`earthly` execute before `tidy`, `lint`, and `export-docs-events`.
This improves maintainability and ensures prerequisites are met.

* chore(ci): update release workflow to use nix and just for releases

Replaced `earthly` with `nix` and `just` in the release workflow.
This improves build consistency and leverages flakes for reproducibility.

* test(mock): add `isgomock` struct to mock types

Added `isgomock` struct to mock types in tests to enhance clarity
and identification of GoMock-generated code structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants