feat: store complete revert transaction result into database

formancehq · Oct 23, 2024 · b6a3020 · b6a3020
1 parent f03c9e2
commit b6a3020
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/internal/controller/ledger/controller_default.go b/internal/controller/ledger/controller_default.go
@@ -134,7 +134,7 @@ func (ctrl *DefaultController) importLog(ctx context.Context, sqlTx TX, log ledg
 			}
 		}
 	case ledger.RevertedTransactionLogPayload:
-		_, _, err := sqlTx.RevertTransaction(ctx, payload.RevertedTransactionID)
+		_, _, err := sqlTx.RevertTransaction(ctx, payload.RevertedTransaction.ID)
 		if err != nil {
 			return errors.Wrap(err, "failed to revert transaction")
 		}
@@ -335,15 +335,15 @@ func (ctrl *DefaultController) RevertTransaction(ctx context.Context, parameters
 			return nil, errors.Wrap(err, "failed to insert transaction")
 		}
 
-		return pointer.For(ledger.NewRevertedTransactionLog(input.TransactionID, reversedTx)), nil
+		return pointer.For(ledger.NewRevertedTransactionLog(*originalTransaction, reversedTx)), nil
 	})
 	if err != nil {
 		return nil, err
 	}
 
 	return &RevertTransactionResult{
 		RevertedTransaction: *originalTransaction,
-		ReversedTransaction:   log.Data.(ledger.RevertedTransactionLogPayload).RevertTransaction,
+		ReversedTransaction: log.Data.(ledger.RevertedTransactionLogPayload).RevertTransaction,
 	}, nil
 }
 

diff --git a/internal/log.go b/internal/log.go
@@ -324,14 +324,26 @@ func NewDeleteAccountMetadataLog(id string, key string) Log {
 }
 
 type RevertedTransactionLogPayload struct {
-	RevertedTransactionID int         `json:"revertedTransactionID"`
-	RevertTransaction     Transaction `json:"transaction"`
+	RevertedTransaction Transaction `json:"revertedTransaction"`
+	RevertTransaction   Transaction `json:"transaction"`
 }
 
-func NewRevertedTransactionLog(revertedTxID int, tx Transaction) Log {
+func (r RevertedTransactionLogPayload) hashValue() any {
+	return struct {
+		RevertedTransactionID int         `json:"revertedTransactionID"`
+		RevertTransaction     Transaction `json:"transaction"`
+	}{
+		RevertedTransactionID: r.RevertedTransaction.ID,
+		RevertTransaction:     r.RevertTransaction,
+	}
+}
+
+var _ hashValuer = (*RevertedTransactionLogPayload)(nil)
+
+func NewRevertedTransactionLog(revertedTx, tx Transaction) Log {
 	return NewLog(RevertedTransactionLogType, RevertedTransactionLogPayload{
-		RevertedTransactionID: revertedTxID,
-		RevertTransaction:     tx,
+		RevertedTransaction: revertedTx,
+		RevertTransaction:   tx,
 	})
 }