feat: let database generate logs dates

formancehq · Oct 16, 2024 · 931b1b3 · 931b1b3
1 parent fe85231
commit 931b1b3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/internal/log.go b/internal/log.go
@@ -86,7 +86,7 @@ type Log struct {
 
 	Type           LogType    `json:"type" bun:"type,type:log_type"`
 	Data           LogPayload `json:"data" bun:"data,type:jsonb"`
-	Date           time.Time  `json:"date" bun:"date,type:timestamptz"`
+	Date           time.Time  `json:"date" bun:"date,type:timestamptz,nullzero"`
 	IdempotencyKey string     `json:"idempotencyKey" bun:"idempotency_key,type:varchar(256),unique,nullzero"`
 	// IdempotencyHash is a signature used when using IdempotencyKey.
 	// It allows to check if the usage of IdempotencyKey match inputs given on the first idempotency key usage.
@@ -172,8 +172,6 @@ func NewLog(payload LogPayload) Log {
 	return Log{
 		Type: payload.Type(),
 		Data: payload,
-		// todo: get from database
-		Date: time.Now(),
 	}
 }
 

diff --git a/internal/storage/bucket/migrations/29-logs-add-memento.sql b/internal/storage/bucket/migrations/29-logs-add-memento.sql
@@ -1,2 +1,3 @@
+--todo: add migration
 alter table "{{.Bucket}}".logs
 add column memento bytea;
diff --git a/internal/storage/bucket/migrations/31-logs-assign-date.sql b/internal/storage/bucket/migrations/31-logs-assign-date.sql
@@ -0,0 +1,2 @@
+alter table "{{.Bucket}}".logs
+alter column date set default (now() at time zone 'utc');
diff --git a/internal/storage/ledger/logs_test.go b/internal/storage/ledger/logs_test.go
@@ -43,8 +43,10 @@ func TestInsertLog(t *testing.T) {
 
 		require.Equal(t, 1, log1.ID)
 		require.NotZero(t, log1.Hash)
+		require.NotEmpty(t, log1.Date)
 
 		// Ensure than the database hashing is the same as the go hashing
+		log1Copy.Date = log1.Date
 		chainedLog1 := log1Copy.ChainLog(nil)
 		require.Equal(t, chainedLog1.Hash, log1.Hash)
 
@@ -59,8 +61,10 @@ func TestInsertLog(t *testing.T) {
 		require.NoError(t, err)
 		require.Equal(t, 2, log2.ID)
 		require.NotZero(t, log2.Hash)
+		require.NotZero(t, log2.Date)
 
 		// Ensure than the database hashing is the same as the go hashing
+		log2Copy.Date = log2.Date
 		chainedLog2 := log2Copy.ChainLog(&log1)
 		require.Equal(t, chainedLog2.Hash, log2.Hash)
 	})
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		alter table "{{.Bucket}}".logs
		alter column date set default (now() at time zone 'utc');