Merge pull request #60 from matiasinsaurralde/issue-55

Implement reference based transaction filter
formancehq · Oct 25, 2021 · 7ff8756 · 7ff8756
2 parents d019096 + 7fdc146
commit 7ff8756
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 1 deletion.
diff --git a/api/http.go b/api/http.go
@@ -89,10 +89,11 @@ func NewHttpAPI(lc fx.Lifecycle, resolver *ledger.Resolver) *HttpAPI {
 
 	r.GET("/:ledger/transactions", func(c *gin.Context) {
 		l, _ := c.Get("ledger")
+		ref := c.Query("reference")
 
 		cursor, err := l.(*ledger.Ledger).FindTransactions(
 			query.After(c.Query("after")),
-			query.Account(c.Query("account")),
+			query.Reference(ref),
 		)
 
 		c.JSON(200, gin.H{

diff --git a/ledger/query/query.go b/ledger/query/query.go
@@ -74,3 +74,9 @@ func Destination(v string) func(*Query) {
 		q.Params["destination"] = v
 	}
 }
+
+func Reference(v string) func(*Query) {
+	return func(q *Query) {
+		q.Params["reference"] = v
+	}
+}
diff --git a/storage/postgres/transactions.go b/storage/postgres/transactions.go
@@ -143,6 +143,12 @@ func (s *PGStore) FindTransactions(q query.Query) (query.Cursor, error) {
 		))
 	}
 
+	if q.HasParam("reference") {
+		in.Where(
+			in.Equal("reference", q.Params["reference"]),
+		)
+	}
+
 	sb := sqlbuilder.NewSelectBuilder()
 	sb.Select(
 		"t.id",

diff --git a/storage/sqlite/transactions.go b/storage/sqlite/transactions.go
@@ -34,6 +34,12 @@ func (s *SQLiteStore) FindTransactions(q query.Query) (query.Cursor, error) {
 		))
 	}
 
+	if q.HasParam("reference") {
+		in.Where(
+			in.Equal("reference", q.Params["reference"]),
+		)
+	}
+
 	sb := sqlbuilder.NewSelectBuilder()
 	sb.Select(
 		"t.id",