feat: ignore idempotency hash from old data

formancehq · Oct 23, 2024 · 7a23797 · 7a23797
1 parent 79fa355
commit 7a23797
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/internal/controller/ledger/log_process.go b/internal/controller/ledger/log_process.go
@@ -52,8 +52,12 @@ func forgeLog[INPUT any, OUTPUT ledger.LogPayload](ctx context.Context, store St
 			return nil, err
 		}
 		if err == nil {
-			if computedHash := ledger.ComputeIdempotencyHash(parameters.Input); log.IdempotencyHash != computedHash {
-				return nil, newErrInvalidIdempotencyInputs(log.IdempotencyKey, log.IdempotencyHash, computedHash)
+			// notes(gfyrag): idempotency hash should never be empty in this case, but data from previous
+			// ledger version does not have this field and it cannot be recomputed
+			if log.IdempotencyHash != "" {
+				if computedHash := ledger.ComputeIdempotencyHash(parameters.Input); log.IdempotencyHash != computedHash {
+					return nil, newErrInvalidIdempotencyInputs(log.IdempotencyKey, log.IdempotencyHash, computedHash)
+				}
 			}
 
 			return pointer.For(log.Data.(OUTPUT)), nil

diff --git a/internal/storage/bucket/migrations/19-logs-add-idempotency-hash.sql b/internal/storage/bucket/migrations/19-logs-add-idempotency-hash.sql
@@ -1,3 +1,2 @@
---todo: add special traitement on code when value is empty
 alter table "{{.Bucket}}".logs
 add column idempotency_hash bytea;