fix(upgrades): upgrades when creating a new ledger on an already migr…

…ation bucket

internal/api/v2/controllers_ledgers_create.go

@@ -35,6 +35,7 @@ func createLedger(systemController system.Controller) http.HandlerFunc {
 			switch {
 			case errors.Is(err, system.ErrInvalidLedgerConfiguration{}) ||
 				errors.Is(err, ledger.ErrInvalidLedgerName{}) ||
+				errors.Is(err, system.ErrBucketUpgrading) ||
 				errors.Is(err, ledger.ErrInvalidBucketName{}):
 				api.BadRequest(w, common.ErrValidation, err)
 			case errors.Is(err, system.ErrLedgerAlreadyExists):

internal/api/v2/controllers_ledgers_create_test.go

@@ -79,6 +79,13 @@ func TestLedgersCreate(t *testing.T) {
 			expectStatusCode:    http.StatusBadRequest,
 			expectErrorCode:     common.ErrValidation,
 		},
+		{
+			name:                "bucket actually upgrading",
+			expectedBackendCall: true,
+			returnErr:           system.ErrBucketUpgrading,
+			expectStatusCode:    http.StatusBadRequest,
+			expectErrorCode:     common.ErrValidation,
+		},
 		{
 			name:                "unexpected error",
 			expectedBackendCall: true,

internal/controller/system/errors.go

@@ -7,6 +7,7 @@ import (
 
 var (
 	ErrLedgerAlreadyExists          = errors.New("ledger already exists")
+	ErrBucketUpgrading 			= errors.New("bucket is upgrading")
 	ErrExperimentalFeaturesDisabled = errors.New("experimental features are disabled")
 )
 

internal/storage/bucket/bucket.go

@@ -15,6 +15,7 @@ type Bucket interface {
 	HasMinimalVersion(ctx context.Context) (bool, error)
 	IsUpToDate(ctx context.Context) (bool, error)
 	GetMigrationsInfo(ctx context.Context) ([]migrations.Info, error)
+	IsInitialized(context.Context) (bool, error)
 }
 
 type Factory interface {

internal/storage/bucket/default_bucket.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	_ "embed"
+	"errors"
 	"fmt"
 	"github.com/formancehq/go-libs/v2/migrations"
 	ledger "github.com/formancehq/ledger/internal"
@@ -22,6 +23,17 @@ type DefaultBucket struct {
 	tracer trace.Tracer
 }
 
+func (b *DefaultBucket) IsInitialized(ctx context.Context) (bool, error) {
+	_, err := GetMigrator(b.db, b.name).GetLastVersion(ctx)
+	if err == nil {
+		return true, nil
+	}
+	if errors.Is(err, migrations.ErrMissingVersionTable) {
+		return false, nil
+	}
+	return false, err
+}
+
 func (b *DefaultBucket) IsUpToDate(ctx context.Context) (bool, error) {
 	return GetMigrator(b.db, b.name).IsUpToDate(ctx)
 }

internal/storage/driver/driver.go

@@ -44,6 +44,21 @@ func (d *Driver) CreateLedger(ctx context.Context, l *ledger.Ledger) (*ledgersto
 	}
 
 	b := d.bucketFactory.Create(l.Bucket)
+	isInitialized, err := b.IsInitialized(ctx)
+	if err != nil {
+		return nil, fmt.Errorf("checking if bucket is initialized: %w", err)
+	}
+	if isInitialized {
+		upToDate, err := b.IsUpToDate(ctx)
+		if err != nil {
+			return nil, fmt.Errorf("checking if bucket is up to date: %w", err)
+		}
+
+		if !upToDate {
+			return nil, systemcontroller.ErrBucketUpgrading
+		}
+	}
+
 	if err := b.Migrate(
 		ctx,
 		make(chan struct{}),

internal/storage/driver/driver_test.go

@@ -209,6 +209,10 @@ func TestLedgersCreate(t *testing.T) {
 	systemStore.EXPECT().
 		CreateLedger(gomock.Any(), l)
 
+	bucket.EXPECT().
+		IsInitialized(gomock.Any()).
+		Return(false, nil)
+
 	bucket.EXPECT().
 		Migrate(gomock.Any(), gomock.Any(), gomock.Any()).
 		Return(nil)

tools/generator/cmd/root.go

@@ -147,19 +147,27 @@ func run(cmd *cobra.Command, args []string) error {
 	)
 
 	logging.FromContext(cmd.Context()).Infof("Creating ledger '%s' if not exists", targetedLedger)
-	_, err = client.Ledger.V2.CreateLedger(cmd.Context(), operations.V2CreateLedgerRequest{
+	_, err = client.Ledger.V2.GetLedger(cmd.Context(), operations.V2GetLedgerRequest{
 		Ledger: targetedLedger,
-		V2CreateLedgerRequest: &components.V2CreateLedgerRequest{
-			Bucket:   &ledgerBucket,
-			Metadata: ledgerMetadata,
-			Features: ledgerFeatures,
-		},
 	})
 	if err != nil {
 		sdkError := &sdkerrors.V2ErrorResponse{}
-		if !errors.As(err, &sdkError) || (sdkError.ErrorCode != components.V2ErrorsEnumLedgerAlreadyExists &&
-			sdkError.ErrorCode != components.V2ErrorsEnumValidation) {
-			return fmt.Errorf("failed to create ledger: %w", err)
+		if !errors.As(err, &sdkError) || sdkError.ErrorCode != components.V2ErrorsEnumNotFound {
+			return fmt.Errorf("failed to get ledger: %w", err)
+		}
+		_, err = client.Ledger.V2.CreateLedger(cmd.Context(), operations.V2CreateLedgerRequest{
+			Ledger: targetedLedger,
+			V2CreateLedgerRequest: &components.V2CreateLedgerRequest{
+				Bucket:   &ledgerBucket,
+				Metadata: ledgerMetadata,
+				Features: ledgerFeatures,
+			},
+		})
+		if err != nil {
+			if !errors.As(err, &sdkError) || (sdkError.ErrorCode != components.V2ErrorsEnumLedgerAlreadyExists &&
+				sdkError.ErrorCode != components.V2ErrorsEnumValidation) {
+				return fmt.Errorf("failed to create ledger: %w", err)
+			}
 		}
 	}